admin_pages_dev: Modified Laravel Configurations#183
Merged
Riyad-Murad merged 1 commit intomainfrom May 21, 2025
Merged
Conversation
Reviewer's GuideUpdated the GitHub Actions production deployment workflow to generate the APP_URL using the production EC2 host secret instead of the staging host. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Riyad-Murad - I've reviewed your changes - here's some feedback:
- Use >> instead of > when echoing APP_URL so you don’t overwrite the previously written APP_KEY line
- Parameterize the port (8000) or default to port 80 for production URLs to avoid hard-coding port numbers
- Consider switching to HTTPS for APP_URL in production to ensure secure connections
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| @@ -23,7 +23,7 @@ jobs: | |||
| working-directory: amp-laravel | |||
| run: | | |||
There was a problem hiding this comment.
suggestion: Streamline .env file creation with a heredoc
Use a heredoc instead of multiple echo calls to avoid overwriting and write all variables in one block. For example:
cat <<EOF > .env.example
APP_KEY=${{ secrets.LARAVEL_APP_KEY }}
APP_URL=http://${{ secrets.EC2_HOST_PRODUCTION }}:8000
DB_CONNECTION=mysql
DB_HOST=${{ secrets.LARAVEL_DATABASE_HOST }}
DB_PORT=${{ secrets.LARAVEL_DATABASE_PORT_NUMBER }}
EOF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
CI: